Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close detached modal after navigation #547

Closed
cmfcmf opened this issue Apr 25, 2021 · 2 comments · Fixed by #556
Closed

Close detached modal after navigation #547

cmfcmf opened this issue Apr 25, 2021 · 2 comments · Fixed by #556

Comments

@cmfcmf
Copy link

cmfcmf commented Apr 25, 2021

Description

The detachted modal does not close after navigating to an item if the navigation does not change the page.
This happens when the user is already on the page corresponding to the search result, and they use keyboard navigation to select a search result.

Reproduction

https://codesandbox.io/s/polished-shadow-1jsh0?file=/app.tsx

Steps

  1. Search for something
  2. Use your keyboard to navigate to a search result
  3. Hit enter

Expected behavior

The detached modal closes (instead only the search results vanish, but the modal remains open).

Environment

  • OS: Windows
  • Browser: Chrome
  • Autocomplete version: ^1.0.0-alpha.46
@francoischalifour
Copy link
Member

Thanks for the bug report @cmfcmf!

We plan to address this problem shortly. We'll keep you updated in the coming days.

And great work on the Docusaurus integration by the way!

@francoischalifour
Copy link
Member

The problem is fixed in 1.0.0-alpha.48 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants