-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(javascript): dependency imports and low-level init (#3596)
- Loading branch information
Showing
11 changed files
with
107 additions
and
155 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 18 additions & 2 deletions
20
clients/algoliasearch-client-javascript/packages/algoliasearch/jest.config.cjs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,24 @@ | ||
| /** @type {import('jest').Config} */ | ||
| module.exports = { | ||
| /** @type {import('jest').Config.InitialOptions} */ | ||
| const baseConfig = { | ||
| preset: 'ts-jest', | ||
| roots: ['__tests__'], | ||
| moduleDirectories: ['../../node_modules'], | ||
| transform: { | ||
| "\\.[jt]sx?$": "babel-jest", | ||
| } | ||
| }; | ||
| /** @type {import('jest').Config} */ | ||
| module.exports = { | ||
| projects: [ | ||
| { | ||
| ...baseConfig, | ||
| testEnvironment: 'jsdom', | ||
| testPathIgnorePatterns: [ '__tests__/algoliasearch.node.test.ts' ], | ||
| }, | ||
| { | ||
| ...baseConfig, | ||
| testEnvironment: 'node', | ||
| testPathIgnorePatterns: [ '__tests__/algoliasearch.browser.test.ts' ], | ||
| }, | ||
| ], | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 4 additions & 50 deletions
54
templates/javascript/clients/algoliasearch/builds/initClients.mustache
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,61 +1,15 @@ | ||
| function initRecommend(initOptions: InitClientOptions = {}): RecommendClient { | ||
| return createRecommendClient({ | ||
| ...commonOptions, | ||
| ...initOptions.options, | ||
| ...initOptions, | ||
| }); | ||
| return recommendClient(initOptions.appId || appId, initOptions.apiKey ||apiKey, initOptions.options); | ||
| } | ||
|
|
||
| function initAnalytics(initOptions: InitClientOptions & InitClientRegion<AnalyticsRegion> = {}): AnalyticsClient { | ||
| if ( | ||
| initOptions.region && | ||
| (typeof initOptions.region !== 'string' || | ||
| !analyticsRegions.includes(initOptions.region)) | ||
| ) { | ||
| throw new Error( | ||
| `\`region\` must be one of the following: ${analyticsRegions.join(', ')}` | ||
| ); | ||
| } | ||
|
|
||
| return createAnalyticsClient({ | ||
| ...commonOptions, | ||
| ...initOptions.options, | ||
| ...initOptions, | ||
| }); | ||
| return analyticsClient(initOptions.appId || appId, initOptions.apiKey ||apiKey, initOptions.region, initOptions.options); | ||
| } | ||
|
|
||
| function initAbtesting(initOptions: InitClientOptions & InitClientRegion<AbtestingRegion> = {}): AbtestingClient { | ||
| if ( | ||
| initOptions.region && | ||
| (typeof initOptions.region !== 'string' || | ||
| !abtestingRegions.includes(initOptions.region)) | ||
| ) { | ||
| throw new Error( | ||
| `\`region\` must be one of the following: ${abtestingRegions.join(', ')}` | ||
| ); | ||
| } | ||
|
|
||
| return createAbtestingClient({ | ||
| ...commonOptions, | ||
| ...initOptions.options, | ||
| ...initOptions, | ||
| }); | ||
| return abtestingClient(initOptions.appId || appId, initOptions.apiKey ||apiKey, initOptions.region, initOptions.options); | ||
| } | ||
|
|
||
| function initPersonalization(initOptions: InitClientOptions & Required<InitClientRegion<PersonalizationRegion>>): PersonalizationClient { | ||
| if ( | ||
| !initOptions.region || (initOptions.region && | ||
| (typeof initOptions.region !== 'string' || | ||
| !personalizationRegions.includes(initOptions.region))) | ||
| ) { | ||
| throw new Error( | ||
| `\`region\` is required and must be one of the following: ${personalizationRegions.join(', ')}` | ||
| ); | ||
| } | ||
|
|
||
| return createPersonalizationClient({ | ||
| ...commonOptions, | ||
| ...initOptions.options, | ||
| ...initOptions, | ||
| }); | ||
| return personalizationClient(initOptions.appId || appId, initOptions.apiKey ||apiKey, initOptions.region, initOptions.options); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.