Skip to content

Commit

Permalink
fix(specs): allow custom fields to be nullable (#2746)
Browse files Browse the repository at this point in the history
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
  • Loading branch information
shortcuts and millotp authored Feb 20, 2024
1 parent 68551ff commit 4f6e2d0
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions scripts/cli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,14 @@ ctsCommand
.addArgument(args.clients)
.option(flags.verbose.flag, flags.verbose.description)
.action(async (langArg: LangArg, clientArg: string[], { verbose }) => {
const { language, clientList } = transformSelection({
const { language, client } = transformSelection({
langArg,
clientArg,
});

setVerbose(Boolean(verbose));

await runCts(language === ALL ? LANGUAGES : [language], clientList);
await runCts(language === ALL ? LANGUAGES : [language], client);
});

ctsCommand
Expand Down
2 changes: 1 addition & 1 deletion scripts/cts/runCts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ async function runCtsOne(language: string): Promise<void> {

// the clients option is only used to determine if we need to start the test server, it will run the tests for all clients anyway.
export async function runCts(languages: Language[], clients: string[]): Promise<void> {
const useTestServer = clients.includes('search');
const useTestServer = clients.includes('search') || clients.includes('all');
let close: () => Promise<void> = async () => {};
if (useTestServer) {
close = await startTestServer();
Expand Down
3 changes: 3 additions & 0 deletions specs/ingestion/common/schemas/source.yml
Original file line number Diff line number Diff line change
Expand Up @@ -138,16 +138,19 @@ CommercetoolsCustomFields:
items:
type: string
description: Inventory custom fields.
nullable: true
price:
type: array
items:
type: string
description: Price custom fields.
nullable: true
category:
type: array
items:
type: string
description: Category custom fields.
nullable: true

SourceBigCommerce:
type: object
Expand Down

0 comments on commit 4f6e2d0

Please sign in to comment.