feat(checker): Do not output anything if there are no conflicting rul…

…es (#134)
prettier · Apr 19, 2018 · ae07ea7 · ae07ea7
1 parent b5d8504
commit ae07ea7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/tools/__snapshots__/checker.test.ts.snap b/tools/__snapshots__/checker.test.ts.snap
@@ -24,13 +24,12 @@ exports[`should be able to check multiple config files 1`] = `
 [error]   trailing-comma
 [error]   typedef-whitespace
 [error]   whitespace
-[log] No conflict rule detected in <cwd>/fixtures/tslint.empty.json
 [error] Unexpected number in JSON at position 1 in <cwd>/fixtures/tslint.error.json"
 `;
 
-exports[`should show success message for conflict rules that is disabled 1`] = `"[log] No conflict rule detected in <cwd>/fixtures/tslint.false.json"`;
+exports[`should show nothing for conflict rules that is disabled 1`] = `""`;
 
-exports[`should show success message for non-conflict rules 1`] = `"[log] No conflict rule detected in <cwd>/fixtures/tslint.empty.json"`;
+exports[`should show nothing for non-conflict rules 1`] = `""`;
 
 exports[`should show usage if there is no filePath 1`] = `"[log] Usage: tslint-config-prettier-check <pathToConfigFile> ..."`;
 

diff --git a/tools/checker.test.ts b/tools/checker.test.ts
@@ -34,13 +34,13 @@ it("should throw parsing error for invalid config", () => {
   expect(process.exitCode).toBe(1);
 });
 
-it("should show success message for non-conflict rules", () => {
+it("should show nothing for non-conflict rules", () => {
   checkFixture("empty");
   expect(getMessage()).toMatchSnapshot();
   expect(process.exitCode).toBe(0);
 });
 
-it("should show success message for conflict rules that is disabled", () => {
+it("should show nothing for conflict rules that is disabled", () => {
   checkFixture("false");
   expect(getMessage()).toMatchSnapshot();
   expect(process.exitCode).toBe(0);

diff --git a/tools/checker.ts b/tools/checker.ts
@@ -14,10 +14,7 @@ export const check = (configFilePaths: string[]) => {
   configFilePaths.forEach((configFilePath) => {
     try {
       const conflictRules = getConflictRules(configFilePath);
-      if (conflictRules.length === 0) {
-        // tslint:disable-next-line:no-console
-        console.log(`No conflict rule detected in ${configFilePath}`);
-      } else {
+      if (conflictRules.length) {
         // tslint:disable-next-line:no-console
         console.error(
           `Conflict rule(s) detected in ${configFilePath}:\n${conflictRules