Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Rename directory option to tsconfigPath or project #23

Closed

Comments

@teoxoy
Copy link
Contributor

teoxoy commented Aug 3, 2019

Coming from dividab/tsconfig-paths#91, tsconfigPaths.loadConfig(path) accepts a file path too not only a directory.

I think the directory option should be renamed to something more descriptive. I have 2 alternatives in mind:

  • tsconfigPath
  • project - will keep things consistent with @typescript-eslint/parser (parserOptions.project) - but it's in no way as descriptive as tsconfigPath

This will be a breaking change!

@JounQin
Copy link
Collaborator

JounQin commented Sep 30, 2019

Let's waiting for the original issue first.

@teoxoy
Copy link
Contributor Author

teoxoy commented Jul 3, 2020

The conclusion of the original issue is that @typescript-eslint/parser will stick to using project.
Do we want to change directory to project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment