-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom timeout management #179
Comments
Hey @alexgolec, great work on tda-api. Thank you! ⭐️ Quick question, are you open to splitting this into 2 separate issues:
|
Found this on discord. Posting here in case it's of value to others. import httpx
fine_grained_timeout = httpx.Timeout(5.0, connect=1.0)
tda_client.session.timeout = fine_grained_timeout |
That's good feedback. I've put together a PR that will address both points. |
Thanks @alexgolec, you're CRUSHING it! |
Is your feature request related to a problem? Please describe.
HTTPX defaults to 5s timeouts, and some users require longer and/or no timeouts.
Describe the solution you'd like
Start using a client object and expose it to the user so they can set their HTTPX settings.
Describe alternatives you've considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: