Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mill dependencies should be defined as compileIvyDeps #69

Closed
lefou opened this issue Oct 20, 2023 · 4 comments · Fixed by #70
Closed

Mill dependencies should be defined as compileIvyDeps #69

lefou opened this issue Oct 20, 2023 · 4 comments · Fixed by #70

Comments

@lefou
Copy link

lefou commented Oct 20, 2023 •
edited
Loading

While analyzing an reported issue to Mill which only occurs in a project using this plugin, I recognized, that API dependencies to Mill (and it's dependencies like os-lib) are defined as ivyDeps, whereas they are supposed to be defined via compileIvyDeps. This is because the correct runtime version is provided by Mill when the plugin is loaded into Mill's classpath and should not be included in the transitive dependency set.
@lefou lefou mentioned this issue Oct 20, 2023
Closed
@carlosedp
Copy link
Collaborator

If there are no drawbacks on this, I can send a fixing PR.

@carlosedp carlosedp mentioned this issue Oct 20, 2023
Merged
@carlosedp
Copy link
Collaborator

I think this might do it...
#70

@carlosedp
Copy link
Collaborator

Publishing is failing... I've pinged Alex to help out since it looks like something related to the gpg key...

@lefou
Copy link
Author

lefou commented Oct 24, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump mill version, split ivyDeps and compileIvyDeps carlosedp/mill-native-image
2 participants
@carlosedp @lefou