Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation shouldn't err or "" #35

Closed
bbatsov opened this issue Feb 2, 2016 · 6 comments
Closed

documentation shouldn't err or "" #35

bbatsov opened this issue Feb 2, 2016 · 6 comments
Labels

Comments

@bbatsov
Copy link
Collaborator

bbatsov commented Feb 2, 2016

cider.nrepl.middleware.complete> (jvm-complete/documentation "")
StringIndexOutOfBoundsException String index out of range: 0  java.lang.String.charAt (String.java:646)

Ideally this should return "" (what happens with unknown symbols).

@bbatsov
Copy link
Collaborator Author

bbatsov commented Feb 2, 2016

More info - clojure-emacs/cider-nrepl#294

@alexander-yakushev
Copy link
Owner

Agreed. Although I would expect CIDER middleware to catch all possible underlying exceptions and send the trace via its internal pipes.

@bbatsov
Copy link
Collaborator Author

bbatsov commented Feb 2, 2016

That was just fixed in the middleware.

@alexander-yakushev
Copy link
Owner

OK. So should I still put a try block around that code? In that case I would just silently swallow exceptions which would make debugging more difficult.

Another thing to do is just to handle empty input to documentation.

@bbatsov
Copy link
Collaborator Author

bbatsov commented Feb 2, 2016

I'd handle empty empty input. Seems like the reasonable thing to do.

@alexander-yakushev
Copy link
Owner

Fixed in e6040df.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants