Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete local bindings #12

Closed
alexander-yakushev opened this issue Jul 17, 2014 · 12 comments
Closed

Complete local bindings #12

alexander-yakushev opened this issue Jul 17, 2014 · 12 comments

Comments

@alexander-yakushev
Copy link
Owner

By leveraging context complete defn arguments and local bindings introduced by let.

Moved from clojure-emacs/cider#660.

@alexander-yakushev
Copy link
Owner Author

I've just written a new source for local bindings and pushed it to 0.1.3-SNAPSHOT. For exhaustive list of supported cases see https://github.com/alexander-yakushev/compliment/blob/master/test/compliment/sources/t_local_bindings.clj.

Cast @bixuanzju, @expez.

@expez
Copy link

expez commented Jul 27, 2014

This looks fantastic. Can't wait to try it out!

@bbatsov: can we bump the nrepl dependency to 0.1.3-SNAPSHOT? That way we can test this for a few days and hopefully release 0.7 with compliment 0.1.3.

@bbatsov
Copy link
Collaborator

bbatsov commented Jul 27, 2014

Done.

@alexander-yakushev
Copy link
Owner Author

@bbatsov, thanks for the feedback!

@bbatsov
Copy link
Collaborator

bbatsov commented Jul 28, 2014

@alexander-yakushev You're welcome. Btw, I did some testing witn 0.1.3-snapshot and cider and nothing seems to have changed. I didn't get completion candidates for local anywhere. Could you look at this?

@alexander-yakushev
Copy link
Owner Author

@bbatsov I forgot to require the new source from compliment.core when I did the last deploy. Now I redeployed 0.1.3-SNAPSHOT with the latest commits, I would appreciate if you tried again.

@bbatsov
Copy link
Collaborator

bbatsov commented Jul 28, 2014

Now it works fine. Or so it seems to me. Let's hear back from @expez as well and you can releases 0.1.3, so I can finally wrap cider 0.7.

@expez
Copy link

expez commented Jul 29, 2014

This is a big improvement! 👍

@bixuanzju
Copy link

That is cool! But I am confused how to use in Cider. Can I just start coding and company will offer completion of local binding? Thank you!

@bbatsov
Copy link
Collaborator

bbatsov commented Jul 29, 2014

@bixuanzju Yes. (provided you're using the latest cider-nrepl snapshot)

@alexander-yakushev I guess you can move forward with the release of 0.1.3.

@bixuanzju
Copy link

@bbatsov Thanks! Worked like magic.

@alexander-yakushev
Copy link
Owner Author

Done and done, 0.1.3 is now deployed to Clojars. Thanks to everyone for cooperation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants