Added special handling for React's onDoubleClick event. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is considered as if it is a custom 'doubleClick' event by jsx-dom. Also added typing for onDblClick event, which is the actual event name.
alex-kinokon
requested changes
May 21, 2023
alex-kinokon
approved these changes
May 22, 2023
|
published as 8.0.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React has a onDoubleClick event but afaik it is eventually mapped to dblclick DOM event (https://developer.mozilla.org/en-US/docs/Web/API/Element/dblclick_event).
Preact Compat has special handling for onDoubleClick (https://github.com/preactjs/preact/blob/87024e8480c6a60bf114d6c69791a87cec0c553a/compat/src/render.js#L146).
Without this patch, jsx-dom considers onDoubleClick as a custom event, and attaches the event handler as a custom event to "doubleClick" event, which does not exist.