Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT_CALLOC TIMEOUT IN MAC M1 (ft_strrchr and ft_memmove still crashed on m1 too) #121

Open
ansulist opened this issue Jan 26, 2022 · 7 comments

Comments

@ansulist
Copy link

Screenshot 2022-01-26 at 10 06 19 AM

I tried in other mac with non-M1 processor and it works fine and properly.

@meelenium
Copy link

meelenium commented Feb 3, 2022

fix ur code)I use m1, and I know that it's okay)

Check ur "while", are there conditions if anything is served?

@peguimasid
Copy link

peguimasid commented May 22, 2022

Same problem here, this first ft_calloc test does not pass even in code that passed in moulinette tests

ft_strrchr and ft_memmove crashing here too, i tried to run the tests in a mac with an intel core i5 and this two tests works perfectly but ft_calloc still TIMEOUT

@timotif
Copy link

timotif commented Aug 27, 2022

Same problem here on M1... but if I maliciously set up my function like this:

#include <string.h>
void	*ft_memmove(void *dst, const void *src, size_t len)
{
	return (memmove(dst, src, len));
}

the result is exactly the same... so I guess I successfully "re-coded the function" as per assignment :-P
Nevertheless I'll spend a bit more time on it for the sake of learning since @iomanetic managed to make it work!

@github-actions
Copy link

github-actions bot commented Sep 3, 2022

Hello! Thanks for contributing to the libft unit test.

Note that this repository is not maintained by the owner anymore, instead there is a bot that will automatically merge any reviewed pull requests.
If you feel like it, here are some links that can help you submiting a change in the code base::

@alcjzk
Copy link

alcjzk commented Oct 26, 2022

The test code is only providing one argument for ft_calloc and causing undefined behaviour.

Edit: looks like there's already a pull request on this! #134

@MalwarePup
Copy link
Contributor

Nevertheless I'll spend a bit more time on it for the sake of learning since @iomanetic managed to make it work!

If you take the code of @iomanetic and test it on your own laptop with M1, you will see the same test result than your code.
The M1 have a problem with this test code that's it.

@MalwarePup
Copy link
Contributor

MalwarePup commented Feb 20, 2023

If the #146 Is accepted, the 2 tests related to ft_strrchr and ft_memmove who crashed will be functional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants