Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VS Code Multi-root Workspaces #82

Closed
alefragnani opened this issue Oct 15, 2017 · 1 comment
Closed

Support VS Code Multi-root Workspaces #82

alefragnani opened this issue Oct 15, 2017 · 1 comment
Assignees
Milestone

Comments

@alefragnani
Copy link
Owner

alefragnani commented Oct 15, 2017

Concept

How I think it should work (initial idea)...

Bookmarks are not shared

Today, bookmarks are saved per folder. When moving to multi-root workspaces, the bookmarks should be saved per workspace and so, no matter how many folders you have added to the workspace, the bookmarks are related to the workspace itself. It means that if you open that same folder, outside the workspace where the bookmark was added, the bookmark will not be seen. And vice-versa.

The bottom line is, the bookmarks are not shared between folders and workspaces

What about saveBookmarksInProject setting

If you have saveBookmarksInProject set to true, the bookmarks should not be saved per workspace but for each folder you have added.

Warning: If you open the same folder in other VS Code instance, you may have issues caused by concurrent access.

Navigation

If you set navigateThroughAllFiles to true, you will be able to navigate thru the entire workspace, not only the folder you have focus inside a workspace. It does not matter how you define saveBookmarksInProject.

Treeview

The bookmarks should be separated/grouped by folder. It does not matter how you define saveBookmarksInProject.

@alefragnani
Copy link
Owner Author

alefragnani commented Nov 11, 2017

Simpler Concept

Difference from the previous idea

The only difference is related to saveBookmarksInProject setting. I don't know if this how many users are effectively using this setting. But for now, it would be disabled for multi-root workspaces. The motivation behind this new concept, is that I wouldn't need to change how bookmarks are loaded/saved, because it would look just for context.workspaceState or the .vscode\bookmarks.json file for the current workspace, instead of merging bookmarks.json file for each root-folder in a mult-root workspace (when using saveBookmarksInProject setting as true.

Doing so, it would be easier to adapt the extension to multi-root concept.

For an initial release, I think it would work just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant