Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The List from All Files command doesn't work well with VSCode 1.12.1 #69

Closed
cateyes99 opened this issue May 15, 2017 · 9 comments
Closed
Labels
bug caused by vscode The issue was caused by a VS Code update
Milestone

Comments

@cateyes99
Copy link

Bookmarks Version: 0.14.1
VSCode Version: 1.12.1
OS Version: OS X EI Capitan 10.11.3

  1. Set up a bookmark in file A.cs, set up another one in B.cs
  2. Now open C.cs which doesn't have any bookmarks in it and stay on this file
  3. Run the command List from All Files in the command bar on the top of the editor window
  4. Observed the behaviour is weird, it seemed like just freshing the current editor of C.cs in a flash and does nothing else, didn't show the drop list of all bookmarks.

NOTE: if staying on the editor of a file which has at least one bookmark and run this command, then it does show the drop list of all bookmarks.

@cateyes99
Copy link
Author

cateyes99 commented May 15, 2017

i think before I upgraded VSCode to 1.12.1 from 1.10.2, Bookmarks 0.14.1 worked fine in this case:

Bookmarks Version: 0.14.1
VSCode Version: 1.10.2
OS Version: OS X EI Capitan 10.11.3

But i could be wrong, I might not have tested that scenario with VSCode 1.10.2

@alefragnani
Copy link
Owner

Yep, that's weird 😄 .

Thanks for reporting. I will take a look...

@ghost
Copy link

ghost commented May 15, 2017

Same here.

Bookmarks Version: 0.14.1
VSCode version: 1.12.1 (f6868fce3eeb16663840eb82123369dec6077a9b)
OS Version: macOS Sierra 10.12.4

@alefragnani alefragnani added this to the 0.15.0 milestone May 21, 2017
@Joolz99
Copy link

Joolz99 commented May 23, 2017

Same for me. Just installed this very useful looking extension. It works fine for bookmarks in the current file - but when using List from All Files, after selecting the command, the bookmark list flashes up and then disappears again.
VS Code version 1.12.2 - Windows 7 Ultimate

@alefragnani
Copy link
Owner

This problem was caused by the latests VS Code updates. I just installed an older version and works just fine.

I will try to fix it tonight. otherwise I will remove the preview feature, until properly fixed.

@alefragnani alefragnani added the caused by vscode The issue was caused by a VS Code update label May 23, 2017
@Joolz99
Copy link

Joolz99 commented May 23, 2017

Thanks. I thought it probably was a VSCode issue since the extension has had such good feedback. Really looking forward to when you get a chance to fix things.

@alefragnani
Copy link
Owner

Confirmed and fixed 👍

I'll release version 0.15.0 with the fix later tonight... Stay tuned ...

@ghost
Copy link

ghost commented May 24, 2017

It works well now. Many thanks.

@Joolz99
Copy link

Joolz99 commented May 24, 2017

Brill! Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug caused by vscode The issue was caused by a VS Code update
Projects
None yet
Development

No branches or pull requests

3 participants