Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate feasibility of migrating ramm-sui to Move 2024 #6

Closed
rockbmb opened this issue Mar 1, 2024 · 2 comments · Fixed by #9
Closed

Investigate feasibility of migrating ramm-sui to Move 2024 #6

rockbmb opened this issue Mar 1, 2024 · 2 comments · Fixed by #9
Assignees
@rockbmb
Labels
enhancement New feature or request

Comments

@rockbmb
Copy link
Contributor

rockbmb commented Mar 1, 2024 •
edited
Loading

Move 2024 introduces changes to Sui Move, among them the addition of enum types to the language.

Migrating the project to use the 2024 edition (an alpha, for the moment) will be useful in #5 to represent a TradeOutput's outcome instead of using just a boolean: a trade can be allowed, or fail because of imbalance rations going askew, or simply because of insufficient balance for the outbound token.
@rockbmb rockbmb added the enhancement New feature or request label Mar 1, 2024
@rockbmb rockbmb self-assigned this Mar 1, 2024
This was referenced Mar 1, 2024
Closed
Merged
Merged
@rockbmb rockbmb closed this as completed in #9 Mar 4, 2024
@rockbmb rockbmb mentioned this issue Mar 6, 2024
Merged
@rockbmb rockbmb reopened this Apr 20, 2024
@rockbmb
Copy link
Contributor Author

rockbmb commented Apr 20, 2024

Sui Move 2024 is currently in its beta edition, and migration does not need to be made manually, see https://github.com/tnowacki/sui/blob/ccbf0c4b86112886abbbea25b7991dd5decd1f0f/docs/content/guides/developer/advanced/move-2024-migration.mdx?ref=blog.sui.io

Reopening.

@rockbmb rockbmb mentioned this issue Apr 20, 2024
Merged
@rockbmb
Copy link
Contributor Author

rockbmb commented Apr 20, 2024

Closed by #23.

@rockbmb rockbmb closed this as completed Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rockbmb rockbmb

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test migration to Sui Move's 2024 (alpha) edition aldrin-labs/ramm-sui
1 participant
@rockbmb