Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.3.0 #13

Closed
orbeckst opened this issue Nov 6, 2022 · 11 comments
Closed

release 0.3.0 #13

orbeckst opened this issue Nov 6, 2022 · 11 comments

Comments

@orbeckst
Copy link
Member

orbeckst commented Nov 6, 2022

First release of the thin-CLI architecture (as described in discussion #12).

This release is backwards incompatible to the previous releases (the original plugin-based architecture). It will be pip installable.

@orbeckst
Copy link
Member Author

orbeckst commented Nov 6, 2022

flamel is already taken on PyPi. Do we have an opinion on the package name?

  • alchemlyb-flamel
  • alchemistry-flamel
  • alchemical-analysis
  • ... better ideas?

cc: @xiki-tempula @dominikwille @davidlmobley

@orbeckst
Copy link
Member Author

orbeckst commented Nov 7, 2022

@xiki-tempula if you're happy with https://pypi.org/project/alchemistry-flamel/0.3.0rc2/ then we can make a release.

@orbeckst
Copy link
Member Author

orbeckst commented Nov 7, 2022

Also let me know who you are on pypi so that I can invite you as a owner of the pypi project (and the one on testpypi).

@orbeckst
Copy link
Member Author

orbeckst commented Nov 7, 2022

Also created https://github.com/alchemistry/flamel/releases/tag/v0.3.0rc2

Eventually, we want to add GH deployment workflow...

@orbeckst
Copy link
Member Author

orbeckst commented Nov 8, 2022

@xiki-tempula are you fine with a 0.3.0 release of flamel?

@xiki-tempula
Copy link
Contributor

@orbeckst Sorry. I'm fine with a rc but I haven't had time to test it more thoroughly so is a bit reluctant to do a formal release. On the other hand, given that we are still at 0.X.X, we could just release a 0.3.1 if I found some other issue with it.

@orbeckst
Copy link
Member Author

orbeckst commented Nov 8, 2022

I ran the tests for the rc2 package and they passed. I think it's "good enough" for 0.3.0. Let's get it out and then fix if there's anything necessary.

@orbeckst
Copy link
Member Author

orbeckst commented Nov 9, 2022

My rc3 is failing the manual installation:

(alchemlyb39_dev) laptop:flamel oliver$ pip install -i https://test.pypi.org/simple/ alchemistry-flamel==0.3.0rc3
Looking in indexes: https://test.pypi.org/simple/
Collecting alchemistry-flamel==0.3.0rc3
  Downloading https://test-files.pythonhosted.org/packages/c4/02/6a1c95c34ca51a826663f6233a52ba6ef2c273f203deee4e8763ab6a3f43/alchemistry_flamel-0.3.0rc3-py3-none-any.whl (8.5 kB)
Collecting alchemlyb>=1.0
  Using cached https://test-files.pythonhosted.org/packages/c6/0a/323a85ede5a46873961f1f0ff0f6764d74895dc73abcfca009794a874fb1/alchemlyb-1.0.0-py3-none-any.whl (85 kB)
ERROR: Could not find a version that satisfies the requirement importlib-resources; python_version < "3.12" (from alchemistry-flamel) (from versions: none)
ERROR: No matching distribution found for importlib-resources; python_version < "3.12"

Need to check, maybe I made a mistake in pyproject.toml.

This is the first one built & deployed by the automatic deployment workflow PR #16.

@orbeckst
Copy link
Member Author

orbeckst commented Nov 9, 2022

Now it worked... maybe had to do some env cleaning. Will cut the 0.3.0

@orbeckst
Copy link
Member Author

orbeckst commented Nov 9, 2022

pip install -i https://test.pypi.org/simple/ alchemistry-flamel==0.3.0

works ... on to the final release!

@orbeckst
Copy link
Member Author

Released, tweeted, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants