-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codecov badge shows coverage from PR and not master #33
Comments
I think this is due to this issue on codecov's end. If the PR is coming from a fork's |
Thanks. Any ideas how to deal with it? |
Maybe we can bypass (though not resolve) by getting people to do PRs from branches rather than forks. But that is not a general solution. |
As I understand it, the problem only occurs if they do a PR from a branch called master on the fork. If they follow normal procedures and create a branch first and do the PR from the branch, the codecov will not become confused. (In fact that is what works for us everywhere else.) |
Not sure this one can be solved by us; it shouldn't generally crop up if PRs don't come from |
For some reason, our codecov badge https://codecov.io/gh/alchemistry/alchemlyb shows the coverage from a PR (in this case 49% from #32) instead of master (which should be around 90%).
Look into how codecov does things.
The text was updated successfully, but these errors were encountered: