Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov badge shows coverage from PR and not master #33

Closed
orbeckst opened this issue Oct 30, 2017 · 5 comments
Closed

codecov badge shows coverage from PR and not master #33

orbeckst opened this issue Oct 30, 2017 · 5 comments

Comments

@orbeckst
Copy link
Member

For some reason, our codecov badge https://codecov.io/gh/alchemistry/alchemlyb shows the coverage from a PR (in this case 49% from #32) instead of master (which should be around 90%).

Look into how codecov does things.

@dotsdl
Copy link
Member

dotsdl commented Oct 30, 2017

I think this is due to this issue on codecov's end. If the PR is coming from a fork's master branch, codecov gets confused.

@orbeckst
Copy link
Member Author

Thanks. Any ideas how to deal with it?

@davidlmobley
Copy link

Maybe we can bypass (though not resolve) by getting people to do PRs from branches rather than forks. But that is not a general solution.

@orbeckst
Copy link
Member Author

As I understand it, the problem only occurs if they do a PR from a branch called master on the fork. If they follow normal procedures and create a branch first and do the PR from the branch, the codecov will not become confused. (In fact that is what works for us everywhere else.)

@dotsdl
Copy link
Member

dotsdl commented Nov 14, 2017

Not sure this one can be solved by us; it shouldn't generally crop up if PRs don't come from master on a fork. Closing for now; reopen if needed.

@dotsdl dotsdl closed this as completed Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants