Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework): modal service #245

Merged
merged 8 commits into from
Feb 5, 2019
Merged

feat(framework): modal service #245

merged 8 commits into from
Feb 5, 2019

Conversation

32penkin
Copy link
Member

@32penkin 32penkin commented Jan 25, 2019 •
edited
Loading

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@32penkin 32penkin changed the title Feat/modal service feat(framework): modal service Jan 25, 2019
@32penkin 32penkin self-assigned this Jan 25, 2019
artyorsh
artyorsh suggested changes Jan 25, 2019
View reviewed changes
src/framework/theme/component/modal/modal.component.tsx Outdated Show resolved Hide resolved
src/framework/theme/component/modal/modal.component.tsx Outdated Show resolved Hide resolved
src/framework/theme/component/modal/modal.component.tsx Outdated Show resolved Hide resolved
src/framework/theme/component/modal/modal.component.tsx Outdated Show resolved Hide resolved
src/framework/theme/component/modal/modal.component.tsx Outdated Show resolved Hide resolved
src/framework/theme/component/modal/modal.spec.tsx Outdated Show resolved Hide resolved
src/framework/theme/component/modal/modal.spec.tsx.snap Show resolved Hide resolved
src/framework/theme/component/modal/modalPanel.component.tsx Outdated Show resolved Hide resolved
src/framework/theme/component/modal/modalPanel.component.tsx Outdated Show resolved Hide resolved
src/playground/src/ui/screen/dialog.component.tsx Outdated Show resolved Hide resolved
@artyorsh artyorsh mentioned this pull request Jan 26, 2019
Merged
2 tasks
artyorsh
artyorsh suggested changes Jan 28, 2019
View reviewed changes
Copy link
Collaborator

@artyorsh artyorsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to follow this?

src/framework/theme/component/modal/modal.component.tsx Outdated Show resolved Hide resolved
artyorsh
artyorsh approved these changes Jan 30, 2019
View reviewed changes
Copy link
Collaborator

@artyorsh artyorsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving 👍

artyorsh
artyorsh suggested changes Jan 31, 2019
View reviewed changes
Copy link
Collaborator

@artyorsh artyorsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts

@32penkin
Copy link
Member Author

32penkin commented Jan 31, 2019 •
edited
Loading

conflicts

merged

@malashkevich malashkevich merged commit 6efa3c5 into next Feb 5, 2019
@malashkevich malashkevich deleted the feat/modal-service branch February 5, 2019 13:07
@malashkevich
Copy link
Member

closes #259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malashkevich malashkevich malashkevich left review comments

@artyorsh artyorsh artyorsh approved these changes

Assignees

@32penkin 32penkin

Labels
➡️ Next Upcoming changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@32penkin @malashkevich @artyorsh