feat(ui): tab-view component #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artyorsh
added
needs review
📱 Components
| return elements.map(this.renderChild); | ||
| }; | ||
|
|
||
| private getComponentStyle = (source: StyleType): StyleType => { |
There was a problem hiding this comment.
let's move it above all render methods
There was a problem hiding this comment.
so we need to do this in each implemented component
probably we can refactor this in future
artyorsh
force-pushed
the
feat/tab-view
branch
from
4b3fcca to
0b3cc68
Compare
| style={{ flex: 1 }} | ||
| key={index} | ||
| activeOpacity={1.0} | ||
| onPress={() => this.onChildPress(index)}> |
There was a problem hiding this comment.
can we remove lambda here?
There was a problem hiding this comment.
There is a need to handle which tab was pressed
Passing index directly to Tab component and wrapping it to Touchable inside it's own implementation could help, but I don't think tab should know it's index
artyorsh
force-pushed
the
feat/tab-view
branch
from
eb75072 to
9341d0f
Compare
32penkin
reviewed
Jan 25, 2019
32penkin
reviewed
Jan 25, 2019
artyorsh
force-pushed
the
feat/tab-view
branch
from
c1892a4 to
73bc434
Compare
malashkevich
approved these changes
Jan 28, 2019
32penkin
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Implements following components: