feat(ui): checkbox component #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artyorsh
added
needs review
📱 Components
| onChange?: (checked: boolean) => void; | ||
| appearance?: string | 'default'; | ||
| status?: string | 'error'; | ||
| size?: string | 'big' | 'small'; |
There was a problem hiding this comment.
Please remove exact values
There was a problem hiding this comment.
currently the same syntax is used in radio component
we can refactor this in each implemented component in future
malashkevich
approved these changes
Jan 28, 2019
malashkevich
approved these changes
Jan 28, 2019
32penkin
reviewed
Jan 28, 2019
|
|
||
| // TODO(ui): checkmark component | ||
|
|
||
| export class CheckMark extends React.Component<Props> { |
There was a problem hiding this comment.
There is such demo component in the "toggle" PR
32penkin
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
implements
CheckBoxcomponent