Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(List): forward ItemT to React's ListProps #1430

Merged
merged 2 commits into from
Jun 4, 2021
Merged

fix(List): forward ItemT to React's ListProps #1430

merged 2 commits into from
Jun 4, 2021

Conversation

Jomik
Copy link
Contributor

@Jomik Jomik commented May 22, 2021

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes #1429

RWOverdijk
RWOverdijk approved these changes May 25, 2021
View reviewed changes
Copy link

@RWOverdijk RWOverdijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Defaults to any so no risk of missing generics.

@malashkevich
Copy link
Member

Thanks for contributing @Jomik!

@malashkevich malashkevich merged commit bdf41d3 into akveo:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RWOverdijk RWOverdijk RWOverdijk approved these changes

@whitestranger7 whitestranger7 whitestranger7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing TypeScript generics forwarding
4 participants
@Jomik @malashkevich @RWOverdijk @whitestranger7