Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabset] Add parameter to nb-route-tabset to sticky at top #505

Open
1 of 2 tasks
JavierFuentes opened this issue Jun 22, 2018 · 2 comments
Open
1 of 2 tasks

[Tabset] Add parameter to nb-route-tabset to sticky at top #505

JavierFuentes opened this issue Jun 22, 2018 · 2 comments

Comments

@JavierFuentes
Copy link

Issue type

I'm submitting a ...

  • bug report
  • feature request

Issue description

Current behavior:
nb-route-tabset doesn't sticky at top and scrolls with all his content.

Expected behavior:
I expect nb-route-tabset can sticky at top with a new parameter to control this behaviour and show all his content in a vertical scrollable div with max available height in mobile and desktop.

@denisobrienirl
Copy link

Folks,

While you're at it, may i suggest to also implement a tab close mechanism. Like, an option to have an 'X' on the tab and when pressed will emit a onClose event or something similar.
I got it added to nb-route-tabset component manually, but have to re-apply after each RC upgrade :(

This is how it looks in my simple implementation:
screenshot from 2018-06-26 22-23-01

Thanks! Keep up the good work!

@nnixaa
Copy link
Collaborator

nnixaa commented Jun 27, 2018

Hey @JavierFuentes, that totally makes sense, labeled as an enhancement.

@denisobrienirl, thanks for the suggestion, let's track it here #288.

@nnixaa nnixaa changed the title Add parameter to nb-route-tabset to sticky at top [Tabset] Add parameter to nb-route-tabset to sticky at top Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants