Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to obsolete before v1.5 #2557

Closed
Horusiath opened this issue Mar 15, 2017 · 7 comments
Closed

What to obsolete before v1.5 #2557

Horusiath opened this issue Mar 15, 2017 · 7 comments

Comments

@Horusiath
Copy link
Contributor

Horusiath commented Mar 15, 2017

Because we want to release v1.2 soon, it would be good to think about things we could possibly remove from v1.5. This way we give people enough time to acknowlege incoming changes. I know each person on @akkadotnet/core team has probably it's own propositions on what should we get rid of, so we can disscuss about it here.

Some of my ideas:

  • Obsolete TypedActor (it's bad, most of the people who actually want to use it think about something closer to this in shape).
  • Obsolete ActorProducerPipelineResolver - it's a flawed implementation, that probably noone is actually using.
  • Possibly also obsolete at least some parts of the ActorProducer itself - in general the pipeline of building an actors is really complicated in current akka implementation and it makes things such as Dependency Injection hard to implement. As we need to provide some alternative to this, this may be obsoleted later.

I will probably find some more parts. Any other ideas?

@alexvaluyskiy
Copy link
Contributor

I think this one should be obsoleted before 1.2 #2553

@alexvaluyskiy
Copy link
Contributor

PersistentView should be removed in 1.5 (deprecated in Scala Akka 2.5)

@Horusiath
Copy link
Contributor Author

Agree on PersistentView, but first we should provide some form of support for persistent queries for the plugins we have under our control.

@Danthar
Copy link
Member

Danthar commented Mar 15, 2017

Took a quick look at the ActorProducerPipelineResolver. Am I correct in stating it allows you to apply a decorator like pattern to your actor ?

@alexvaluyskiy
Copy link
Contributor

@Horusiath We could also deprecate Actor DSL https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka/Actor/Dsl/Act.cs

It is an interesting idea to have this DSL, but should it be a part of the core library?

@Aaronontheweb
Copy link
Member

@alexvaluyskiy nah, keep it. It's not doing any harm by staying there and it does get used.

@Aaronontheweb
Copy link
Member

In general, don't deprecate things because we can. Deprecate them because they are either broken abstractions or they've been / will be replaced with something better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants