Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage Logic and Actor logging with ID #991

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Conversation

seglo
Copy link
Contributor

@seglo seglo commented Nov 28, 2019

Purpose

Prefix each Akka Stream graph stage logic and KafkaConsumerActor log statement with a 5 character UID to make it easier to troubleshoot logging when multiple streams or partitioned sources are being used.

References

Changes

  • Update all stage logics with StageIdLogging
  • Update KafkaConsumerActor with ActorIdLogging

Background Context

I used something like this to troubleshoot problems with partitioned sources and the transactional partitioned source PRs (#930)

@seglo seglo changed the title LoggingWithId impl Stage Logic and Actor logging with ID Nov 28, 2019
@seglo seglo requested a review from ennru November 28, 2019 20:14
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great implementation for this cross-cutting concern.
LGTM.

@seglo seglo merged commit bd574ff into akka:master Nov 29, 2019
@seglo seglo deleted the seglo/stage-ids branch November 29, 2019 14:45
@seglo
Copy link
Contributor Author

seglo commented Nov 29, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants