CommittableOffsetBatch: Handle multiple committer refs #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seglo
approved these changes
Oct 25, 2019
| * | ||
| * This should be case class to be comparable based on consumerActor and commitTimeout. This comparison is used in [[CommittableOffsetBatchImpl]]. | ||
| * Sends [[akka.kafka.internal.KafkaConsumerActor.Internal.Commit]] and | ||
| * [[akka.kafka.internal.KafkaConsumerActor.Internal.CommitSingle]] messages to the consumer actor. |
There was a problem hiding this comment.
We could add CommitWithoutReply too for completeness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Harden the
CommittableOffsetBatchso it can aggregate offsets with committer refs from several consumer stages/actors.References
Problem reported in #942
Changes
(Reviewing per commit might make sense)
equalsinKafkaAsyncConsumerCommitterRefBackground Context
The
CommittableOffsetBatchguarded against batching offsets for the same group ID that came from different consumer stages/actors. That becomes a problem for unusual flow topologies, and when aRestartSourceis used.