Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testkit: Allow users to pass broker configuration to test containers #933

Closed
seglo opened this issue Oct 15, 2019 · 1 comment
Closed

Testkit: Allow users to pass broker configuration to test containers #933

seglo opened this issue Oct 15, 2019 · 1 comment
Labels
Milestone

Comments

@seglo
Copy link
Contributor

seglo commented Oct 15, 2019

Short description

Allow the user to pass arbitrary Kafka broker config to test containers managed by the testkit.

Details

Test containers allows users to configure the underlying service using environment variables. Kafka broker configuration can be overridden with environment variables, so it would be useful to allow users to provide arbitrary config to the test container before it starts up.

On a related note, the test container will only start up once for the entire test suite. Is there a way to configure test containers to spin up per test class, or test method, each with its own config?

@ennru
Copy link
Member

ennru commented Oct 24, 2019

This was made possible with #939.

@ennru ennru closed this as completed Oct 24, 2019
@ennru ennru added this to the 2.0.0 milestone Oct 24, 2019
@ennru ennru added the testkit label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants