Testkit & tests: Sort out some dependencies with security warnings #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seglo
reviewed
Oct 10, 2019
There was a problem hiding this comment.
Seems to be a bug with the integration build.
Exception in thread "shutdownHook1" java.lang.NoSuchMethodError: akka.actor.ActorSystem.shutdown()V
at com.github.ehsanyou.sbt.docker.compose.DockerCompose$.$anonfun$actorSystem$1(DockerCompose.scala:74)
at scala.sys.ShutdownHookThread$$anon$1.run(ShutdownHookThread.scala:33)
https://travis-ci.org/akka/alpakka-kafka/jobs/595824305#L7972
|
Yes, the docker-compose plugin is compiled against an old Akka version, that doesn't affect the tests though. |
ennru
changed the title
johanandren
approved these changes
Oct 10, 2019
patriknw
reviewed
Oct 10, 2019
| "org.scalatest" %% "scalatest" % scalatestVersion % Test, | ||
| "io.spray" %% "spray-json" % "1.3.5" % Test, | ||
| "com.fasterxml.jackson.core" % "jackson-databind" % "2.9.8" % Test, // ApacheV2 | ||
| "com.fasterxml.jackson.core" % "jackson-databind" % "2.10.0" % Test, // ApacheV2 |
There was a problem hiding this comment.
good that we are using the same Jackson version in all Lightbend products (Akka, Play, Lagom, ...)
There was a problem hiding this comment.
This is just in the non-published tests, in the testkit I didn't dare to go past 2.9.10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Avoid security warnings for vulnerable libraries.
Changes