Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConsumerSetting: Add group instance id setter #861

Merged
merged 2 commits into from
Dec 2, 2019
Merged

ConsumerSetting: Add group instance id setter #861

merged 2 commits into from
Dec 2, 2019

Conversation

def1ne
Copy link
Contributor

@def1ne def1ne commented Aug 13, 2019

Purpose

Update Kafka dependency and add method withGroupInstanceId to ConsumerSettings.

References

References #859

@ennru
Copy link
Member

ennru commented Aug 14, 2019

Thank you for this PR.
As it changes the Kafka client library version, we won't include it in patch releases, but need to defer it until version 2.0.

Are you aware that you can achieve this feature by overriding the Kafka client library version yourself and setting the property with the withProperty method?

@ennru ennru added this to the 2.0.0 milestone Aug 14, 2019
@def1ne
Copy link
Contributor Author

def1ne commented Aug 20, 2019 •
edited
Loading

We overrode the Kafka client version to 2.3.0 and set property through withProperty. All works fine.

@ennru ennru added the core label Sep 17, 2019
@ennru ennru force-pushed the static-membership-support branch from babe313 to 27adac1 Compare December 2, 2019 07:59
@ennru
Copy link
Member

ennru commented Dec 2, 2019

I've rebased this PR on master which will go into Alpakka Kafka 2.0.0-M1.

ennru
ennru approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru changed the title Updated kafka version to 2.3.0. Added group instance id setter. ConsumerSetting: Add group instance id setter Dec 2, 2019
@ennru ennru merged commit b12496f into akka:master Dec 2, 2019
@ennru
Copy link
Member

ennru commented Dec 2, 2019

Thank you for your contribution!

@ennru ennru mentioned this pull request Jan 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
2.0.0-M2
Development

Successfully merging this pull request may close these issues.
2 participants
@def1ne @ennru