Update protobuf dependency in tests #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
commented
Sep 19, 2022
| @@ -269,7 +269,7 @@ lazy val tests = project | |||
| // Schema registry uses Glassfish which uses java.util.logging | |||
| "org.slf4j" % "jul-to-slf4j" % slf4jVersion % Test, | |||
| "org.mockito" % "mockito-core" % "4.7.0" % Test, | |||
| "com.thesamet.scalapb" %% "scalapb-runtime" % "0.10.11" % Test | |||
| "com.thesamet.scalapb" %% "scalapb-runtime" % "0.11.11" % Test | |||
There was a problem hiding this comment.
this depends on protobuf-java 3.19.2, but latest patch 3.19.5 should be fine
patriknw
force-pushed
the
wip-proto-dep-patriknw
branch
from
04b1f40 to
7517085
Compare
patriknw
force-pushed
the
wip-proto-dep-patriknw
branch
from
7517085 to
1733ad0
Compare
patriknw
force-pushed
the
wip-proto-dep-patriknw
branch
from
1733ad0 to
e8da1ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE-2021-22569, but only in test code.