Cluster-sharding: single listener per entity type key + Java DSL #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way if it is loaded multiple times only one actor is created. Also remove the method that takes in an actor system. We shouldn't allow an extension from one system to use another system
patriknw
approved these changes
Mar 17, 2020
cluster-sharding/src/main/scala/akka/kafka/cluster/sharding/KafkaClusterSharding.scala
Show resolved
Hide resolved
ennru
approved these changes
Mar 17, 2020
| } | ||
|
|
||
| public static void example() { | ||
| ActorSystem<Void> typedSystem = ActorSystem.create(Behaviors.empty(), "ClusterShardingExample"); |
There was a problem hiding this comment.
It should just be system as in other examples.
| import akka.actor.typed.scaladsl.Behaviors | ||
| import akka.actor.typed.scaladsl.adapter._ | ||
| import akka.actor.{ExtendedActorSystem, Extension, ExtensionId} | ||
| import akka.actor.{ActorSystem, ClassicActorSystemProvider, ExtendedActorSystem, Extension, ExtensionId} |
There was a problem hiding this comment.
Use the FCQN for ActorSystem instead of importing it to make it more clear.
|
Travis wants you to |
|
Then I shall do what travis wants |
ennru
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way if it is loaded multiple times only one actor is created.
Also remove the method that takes in an actor system. We shouldn't allow
an extension from one system to use another system
Adds a Java API + docs