Java API createCommittableOffsetBatch accepts Committable #1033
Conversation
jewertow
changed the title
| @@ -181,7 +181,7 @@ object ConsumerMessage { | |||
| * Java API: | |||
| * Create an offset batch out of a list of offsets. | |||
| */ | |||
| def createCommittableOffsetBatch(offsets: java.util.List[CommittableOffset]): CommittableOffsetBatch = { | |||
| def createCommittableOffsetBatch[T <: Committable](offsets: java.util.List[T]): CommittableOffsetBatch = { | |||
There was a problem hiding this comment.
The test I added proves that the type of this list has to be T <: Committable istead of Committable, but both types Committable and T <: Committable are binary-incompatible.
There was a problem hiding this comment.
Agreed. This seems fine to me. It's binary-incompatible, but since it's only widening permitted types it shouldn't break anything that was using the previous method.
| records.stream().map(ConsumerRecord::value).collect(Collectors.joining(",")); | ||
| return ProducerMessage.single(new ProducerRecord<>(topic2, key, value)); | ||
| }) | ||
| .mapContext(ConsumerMessage::createCommittableOffsetBatch) |
There was a problem hiding this comment.
In case of def createCommittableOffsetBatch(offsets: java.util.List[Committable]) it wouldn't compile.
| @@ -181,7 +181,7 @@ object ConsumerMessage { | |||
| * Java API: | |||
| * Create an offset batch out of a list of offsets. | |||
| */ | |||
| def createCommittableOffsetBatch(offsets: java.util.List[CommittableOffset]): CommittableOffsetBatch = { | |||
| def createCommittableOffsetBatch[T <: Committable](offsets: java.util.List[T]): CommittableOffsetBatch = { | |||
There was a problem hiding this comment.
Agreed. This seems fine to me. It's binary-incompatible, but since it's only widening permitted types it shouldn't break anything that was using the previous method.
| records.stream().map(ConsumerRecord::value).collect(Collectors.joining(",")); | ||
| return ProducerMessage.single(new ProducerRecord<>(topic2, key, value)); | ||
| }) | ||
| .mapContext(ConsumerMessage::createCommittableOffsetBatch) |
Purpose
The Java API
createCommittableOffsetBatchrequires a list ofCommittableOffsetwhere it should allowCommittable(as the Scala API does in apply).References
#1020