Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Skip backtracking, PubSub after idle (backport 1.2) #615

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

patriknw
Copy link
Member

Backport of #614

  • feat: Accept PubSub events after idle

    • PubSub events are ignored if they are too far ahead of backtracking.
    • That means that they will always be ignored after an idle period.
    • This emits heartbeat events when the query is idle and thereby progress the backtracking timestamp in the PubSub filter.
    • base relative heartbeat timestamps on initial database time
    • previous query wall clock minus backtracking behind current time
    • including fake persistenceId corresponding to the slice
    • don't deduplicate heartbeat
    • mima filter
    • unique heartbeat persistenceId
    • filter heartbeats early in pubsub merge
  • feat: Skip backtracking when far behind


Co-authored-by: Peter Vlugter 59895+pvlugter@users.noreply.github.com
(cherry picked from commit c7899d1)

…le (#614)

* feat: Accept PubSub events after idle
  * PubSub events are ignored if they are too far ahead of backtracking.
  * That means that they will always be ignored after an idle period.
  * This emits heartbeat events when the query is idle and thereby progress
    the backtracking timestamp in the PubSub filter.
  * base relative heartbeat timestamps on initial database time
  * previous query wall clock minus backtracking behind current time
  * including fake persistenceId corresponding to the slice
  * don't deduplicate heartbeat
  * mima filter
  * unique heartbeat persistenceId
  * filter heartbeats early in pubsub merge

* feat: Skip backtracking when far behind

---------

Co-authored-by: Peter Vlugter <59895+pvlugter@users.noreply.github.com>
(cherry picked from commit c7899d1)
@patriknw patriknw changed the base branch from main to release-1.2 October 18, 2024 08:19
@patriknw
Copy link
Member Author

hm, why isn't ci running here

@patriknw patriknw closed this Oct 18, 2024
@patriknw patriknw reopened this Oct 18, 2024
@patriknw patriknw merged commit ee94b5e into release-1.2 Oct 18, 2024
8 of 17 checks passed
@patriknw patriknw deleted the wip-heartbeat-catchup-1.2-patriknw branch October 18, 2024 09:26
@patriknw patriknw added this to the 1.2.6 milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant