-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bookmark sections #64
Comments
One problem I foresee is that there doesn't seem to be any id to link to. |
@b3u Thanks for submitting the issue! And thanks for the visual to help me better understand what you're looking for. It's something I've thought about before. You wrote:
Could you share a more details about the use case? What might the frequent reader be switching between? I'm trying to better understand the issue before jumping to a specific solution. |
@akivajgordon Sure. I may be (1) practicing a parsha a couple weeks in advance, (2) going over the weekly parsha while I'm in front of a tikkun, and (3) reviewing the reading and the maftir for an upcoming holiday. Admittedly, 1 and 2 are placed near each other, while 3 can be solved by adding hints for special readings. Another example is someone preparing for Megillas Esther. They want to be well prepared, as it is a long reading, but they also want to lein a parsha a month or so beforehand. |
Thanks for elaborating. For all of those use cases, except for (3), I don't think it's worth adding additional UI in order to jump around – I think the current way isn't too much friction to finding a parsha, especially with the fuzzy search that a frequent reader would discover naturally. As for (3), I plan to be adding all of the holiday readings as well in a similar manner to how the rest are displayed today. Again, not too much friction if you ask me. E.g. I want to jump between Esther and Matot - to get to Esther, I type / to bring up the navigation, then "Est" Enter, then back to Matot with /matEnter. It's pretty quick. Even just finding it from the list isn't too much of a struggle in my opinion. Sorry if it sounds like I'm dismissing the idea too much, but this feels like a feature whose upside is too minimal to warrant additional UI. I'm not opposed to adding new UI, but since there will undoubtedly be more, I'd want to limit it to where it really needs to be there. I love your enthusiasm with the features though, so please keep them coming! Closing for now, but happy to continue the discussion and I'm willing to re-open if the use-case is there. |
Description: A frequent leiner may want to bookmark a couple locations, for easy switching and finding.
Notes
The implementation could include an array of locations kept in Local Storage. It would be similar to #39. For the design, something similar to this 👇 might work.
The text was updated successfully, but these errors were encountered: