Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo scrolling layout #136

Open
SLaks opened this issue Oct 21, 2024 · 0 comments
Open

Redo scrolling layout #136

SLaks opened this issue Oct 21, 2024 · 0 comments

Comments

@SLaks
Copy link
Contributor

SLaks commented Oct 21, 2024

The current scrolling layout (overflow: auto in the book element) has a couple of issues:

  • If you resize the browser, the book height doesn't update, leading to duplicate scrollbars if you shrink or unused space if you expand
  • On mobile, scrolling down doesn't hide the browser address bar (this only happens when scrolling the root element)

I will fix this by changing the top bar to be position: sticky.

For simplicity, I will probably only do this after my big PR is merged (my big PR moves some scrolling code, so this fix would conflict with it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant