Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark end of a reading for clarity #133

Open
mzrascoff opened this issue Oct 11, 2024 · 2 comments
Open

Mark end of a reading for clarity #133

mzrascoff opened this issue Oct 11, 2024 · 2 comments

Comments

@mzrascoff
Copy link

Screenshot 2024-10-11 at 3 09 07 PM

I love Tikkun.io. Thank you for building this beautiful site.

Small bug: The Yom Kippur layning should end at 16:34. It erroneously continues into chapter 17.

https://tikkun.io/#/h/yom-kippur

Matthew

@akivajgordon
Copy link
Owner

@mzrascoff First, thanks for the kind words! I'm glad you like it. And thanks for raising this issue.

The current behavior is intentional, so that you have context of the column you would expect to see as the reader. The app does consider the end of the reading in the correct place, but if I'm understanding the deeper pain here, it sounds like it would be a good feature to mark the end of the reading, which tikkun.io currently does not; I'll take this as a feature request!

I'll update this issue to reflect that concept. Thanks again!

@akivajgordon akivajgordon changed the title Mistake in Yom Kippur layning Mark end of a reading for clarity Oct 14, 2024
@SLaks
Copy link
Contributor

SLaks commented Oct 16, 2024

#129 already implements this (but it's not yet ready)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants