Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename book/chapter/verse fields in pages JSON to be consistent #130

Open
SLaks opened this issue Oct 6, 2024 · 0 comments
Open

Rename book/chapter/verse fields in pages JSON to be consistent #130

SLaks opened this issue Oct 6, 2024 · 0 comments

Comments

@SLaks
Copy link
Contributor

SLaks commented Oct 6, 2024

The Ref type uses b, c, and v.

In contrast, the JSON files in data/pages use book, chapter, and verse.

This makes these objects hard to use together. As a followup to my Calendar refactor (#129; this will replace all references to these fields), can you please rename the fields in the JSON generator to be consistent?

Please also delete the aliyot field from the pages; this is already unused.

These will also reduce the filesize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant