Skip to content

Remove cached types from HelpWriter #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akamsteeg opened this issue Sep 7, 2018 · 0 comments
Closed

Remove cached types from HelpWriter #51

akamsteeg opened this issue Sep 7, 2018 · 0 comments
Assignees
Milestone

Comments

@akamsteeg
Copy link
Owner

In HelpWriter, we cache the types of DisplayAttribute and RequiredAttribute but that serves no purpose besides making the object bigger.

/// <summary>
/// Gets the cached <see cref="Type"/> of <see cref="DisplayAttribute"/>
/// </summary>
private readonly Type cachedDisplayAttributeType;
/// <summary>
/// Gets the cached <see cref="Type"/> of <see cref="RequiredAttribute"/>
/// </summary>
private readonly Type cachedRequiredAttributeType;

We should remove those cached instances.

@akamsteeg akamsteeg added this to the 3.0.0 milestone Sep 7, 2018
@akamsteeg akamsteeg changed the title Removed cached types from HelpWriter Remove cached types from HelpWriter Sep 7, 2018
@akamsteeg akamsteeg self-assigned this Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant