Skip to content

PrefixedKeyConsoleHelpWriter is abstract but shouldn't be #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akamsteeg opened this issue Sep 6, 2018 · 0 comments
Closed

PrefixedKeyConsoleHelpWriter is abstract but shouldn't be #45

akamsteeg opened this issue Sep 6, 2018 · 0 comments
Assignees
Milestone

Comments

@akamsteeg
Copy link
Owner

Currently, PrefixedKeyConsoleHelpWriter is an abstract class:

However, I don't think that it should be. It's a complete implementation of IHelpWriter that can work on its own. Now we're forcing people to extend it, just to call the constructor of the abstract base class PrefixedKeyConsoleHelpWriter. It's clean, because it forces strong-typed help writers, but it also makes introducing a new one for a 3rd-party thing much more involved.

Suggestion: Remove the abstract modified from PrefixedKeyConsoleHelpWriter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant