Skip to content

ArgumentPropertiesHelper and ValidationHelper can easily be static, but aren't #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akamsteeg opened this issue Jun 9, 2018 · 0 comments
Assignees
Milestone

Comments

@akamsteeg
Copy link
Owner

akamsteeg commented Jun 9, 2018

The ArgumentPropertiesHelper and ValidationHelper can easily be static, but they aren't. Making them static reduces GC load and calling static methods is cheaper, so we should make them static.

Because these classes are internal, it doesn't change the external API so no major or minor release is needed for this.

@akamsteeg akamsteeg added this to the 2.0.1 milestone Jun 9, 2018
@akamsteeg akamsteeg self-assigned this Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant