Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline builder images #43

Open
ynohat opened this issue Nov 9, 2020 · 0 comments
Open

Streamline builder images #43

ynohat opened this issue Nov 9, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ynohat
Copy link
Contributor

ynohat commented Nov 9, 2020

With #42 we pinned all builder images to alpine 3.11, matching the BASE in dockerfiles/base.Dockerfile. This ensures
a matching distribution and interpreter runtime between builders and final images.

The problem is that it is hardcoded and duplicated across a few files, a minor maintainability issue.

Would it make sense to either:

  • have a build arg to indicate which Alpine version we're using
    • implies that all builder base images should include the alpine version in the tag, e.g. golang:alpine3.11
  • have one builder image base with all runtimes (node, goloang etc...), using akamai/base as BASE
  • use akamai/base as the base for all builders, and install runtimes manually in each dockerfile

I think I like the "one builder image base" option, because it gives a lot of control, but I haven't thought through all the implications.

@ynohat ynohat added the enhancement New feature or request label Nov 9, 2020
@ynohat ynohat self-assigned this Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant