Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a different recursive algorithm to accumulate the desired number of valence states in bond type assignment #107

Open
ajkerr0 opened this issue Jan 18, 2018 · 0 comments

Comments

@ajkerr0
Copy link
Owner

ajkerr0 commented Jan 18, 2018

Per Section 2.3 (http://wanglab.ucsd.edu/html/publications/Atom_type.pdf):
Now the code (I believe) accumulates all of the valence states of a particular total penalty score then cuts off the array up to that number, rather than only accumulating that value.

This might be a matter of going breadth-first rather than depth-first, for example. I need to think about this more to really know what has to be done. This is a lower priority than getting bond type assignment to work full stop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant