Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not provide the watch id for a video that is not public #209

Closed
NDevTK opened this issue Dec 28, 2019 · 3 comments
Closed

Do not provide the watch id for a video that is not public #209

NDevTK opened this issue Dec 28, 2019 · 3 comments

Comments

@NDevTK
Copy link
Contributor

NDevTK commented Dec 28, 2019

Description

I think videos that are not public should not be exposed to the server. (or public as db is public)
This should affect both private and unlisted videos.

Suggested options

  • Prompt user
  • Do not send request to server
  • Use a substring of a hard to compute hash when no times are submitted

Detection

let Public = (document.getElementsByClassName("style-scope ytd-badge-supported-renderer")[2].innerText === "");

@ajayyy
Copy link
Owner

ajayyy commented Dec 28, 2019

I use unlisted videos for debugging purposes, so this will have to be optional. This is a good idea.

@NDevTK
Copy link
Contributor Author

NDevTK commented Dec 28, 2019

A prompt would probably be the easiest to add. (and still allow for debugging)
However "a substring of a hard to compute hash when no times are submitted" would
probably be a nice feature to have.

@NDevTK
Copy link
Contributor Author

NDevTK commented Dec 28, 2019

PR: #224

@ajayyy ajayyy closed this as completed Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants