Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Theme): (Solarized Dark uses wrong text color) #5130 #5422

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

ratulSharker
Copy link
Contributor

Issue #5130:

Description of changes:

  • changed the solarized theme primary color from #93A1A1 to #839496.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@marinsokol5
Copy link
Contributor

It's a slightly lower contract ratio but acceptable at 4.7

@marinsokol5
Copy link
Contributor

But yeah looks good indeed according to the docs.

@marinsokol5
Copy link
Contributor

Thanks for the contribution!

@marinsokol5 marinsokol5 merged commit 114a5c1 into ajaxorg:master Dec 12, 2023
1 check passed
@ratulSharker
Copy link
Contributor Author

Hi @marinsokol5,

Thanks for prompt response and review. I am new to ace community. Can you please explain about what do you meant in contract ratio ?

I did not understand the comment:

It's a slightly lower contract ratio but acceptable at 4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants