Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vite build and webpack warning #5192

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Fix vite build and webpack warning #5192

merged 4 commits into from
Jun 20, 2023

Conversation

nightwing
Copy link
Member

@nightwing nightwing commented Jun 5, 2023

fix build failing with vite and the warning from webpack #5099.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 94.11% and project coverage change: +0.15 🎉

Comparison is base (df2ecbe) 86.98% compared to head (e8ac042) 87.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5192      +/-   ##
==========================================
+ Coverage   86.98%   87.13%   +0.15%     
==========================================
  Files         565      564       -1     
  Lines       45107    45029      -78     
  Branches     6931     6913      -18     
==========================================
+ Hits        39235    39237       +2     
+ Misses       5872     5792      -80     
Flag Coverage Δ
unittests 87.13% <94.11%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/css/editor-css.js 100.00% <ø> (ø)
src/theme/textmate-css.js 100.00% <ø> (ø)
src/theme/tomorrow-css.js 100.00% <ø> (ø)
src/config.js 84.37% <91.66%> (+3.47%) ⬆️
src/lib/keys.js 100.00% <100.00%> (ø)
src/theme/textmate.js 100.00% <100.00%> (ø)
src/theme/tomorrow.js 100.00% <100.00%> (ø)
src/virtual_renderer.js 78.74% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nightwing nightwing changed the title Vite Fix vite build and webpack warning Jun 20, 2023
@InspiredGuy InspiredGuy merged commit e14902e into master Jun 20, 2023
@InspiredGuy InspiredGuy deleted the vite branch June 20, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants