Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for scrollAnimation overriding subsequent scrollTop changes #4993

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

piotrduperas
Copy link
Contributor

#4992

Fix for scrollAnimation overriding subsequent scrollTop changes.
Animation is now interrupted when scrollCursorIntoView is called.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 86.09% // Head: 86.08% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (8a41fe2) compared to base (794fef3).
Patch coverage: 18.18% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4993      +/-   ##
==========================================
- Coverage   86.09%   86.08%   -0.02%     
==========================================
  Files         546      546              
  Lines       41550    41558       +8     
  Branches     6549     6551       +2     
==========================================
+ Hits        35774    35776       +2     
- Misses       5776     5782       +6     
Flag Coverage Δ
unittests 86.08% <18.18%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/virtual_renderer.js 79.37% <18.18%> (-0.46%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrewnester andrewnester merged commit 0092f3f into ajaxorg:master Nov 11, 2022
@andrewnester
Copy link
Contributor

Thank you! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants