Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 violations for all files in the asv/plugins/ directory #1044

Closed
dorothykiz1 opened this issue Feb 21, 2022 · 5 comments · Fixed by #1088
Closed

Fix flake8 violations for all files in the asv/plugins/ directory #1044

dorothykiz1 opened this issue Feb 21, 2022 · 5 comments · Fixed by #1088

Comments

@dorothykiz1
Copy link
Contributor

dorothykiz1 commented Feb 21, 2022

We are trying to clean out all the files to follow Flake8 standards

Use this guide below to install flake8 and how to use it.
Flake8 guide

Here are a few steps to follow:

  • You will be required to remove the files you would like to work on from the setup. cfg file under the extend attribute .
  • Create a virtual environment virtualenv venv venv will be the name for the environment and activate it by running source venv/bin/activate these commands are dependent on the operating system. (These are Linux commands, you can find for windows and macOS online)
  • Run pip install flake8 to install flake8
  • Run flake8 --exclude="" asv/plugins/ .
  • Work on all the highlighted errors

Expected errors to be fixed:

asv/plugins/summarylist.py:5:1: F401 'six' imported but unused
asv/plugins/summarylist.py:15:1: E303 too many blank lines (3)
asv/plugins/summarylist.py:94:60: E226 missing whitespace around arithmetic operator
asv/plugins/virtualenv.py:8:1: F401 'six' imported but unused
asv/plugins/virtualenv.py:54:13: F401 'virtualenv' imported but unused
asv/plugins/git.py:36:28: E127 continuation line over-indented for visual indent
asv/plugins/git.py:69:17: W503 line break before binary operator
asv/plugins/git.py:152:9: F841 local variable 'err' is assigned to but never used
asv/plugins/__init__.py:2:1: W391 blank line at end of file
asv/plugins/conda.py:7:1: F401 'multiprocessing' imported but unused
asv/plugins/conda.py:9:1: F401 'six' imported but unused
asv/plugins/conda.py:25:1: E302 expected 2 blank lines, found 1
asv/plugins/conda.py:183:100: E501 line too long (116 > 99 characters)
asv/plugins/conda.py:187:100: E501 line too long (104 > 99 characters)
asv/plugins/mercurial.py:12:1: F841 local variable 'exc' is assigned to but never used
asv/plugins/mercurial.py:94:16: F523 '...'.format(...) has unused arguments at position(s): 2
asv/plugins/regressions.py:7:1: F401 'six' imported but unused
asv/plugins/regressions.py:58:28: E128 continuation line under-indented for visual indent
asv/plugins/regressions.py:145:100: E501 line too long (103 > 99 characters)
asv/plugins/regressions.py:148:73: E226 missing whitespace around arithmetic operator
asv/plugins/regressions.py:161:100: E501 line too long (101 > 99 characters)
asv/plugins/regressions.py:170:86: E226 missing whitespace around arithmetic operator
asv/plugins/regressions.py:177:100: E501 line too long (103 > 99 characters)
asv/plugins/regressions.py:198:100: E501 line too long (106 > 99 characters)
asv/plugins/regressions.py:250:44: E127 continuation line over-indented for visual indent
asv/plugins/regressions.py:309:35: E128 continuation line under-indented for visual indent
asv/plugins/regressions.py:332:100: E501 line too long (104 > 99 characters)

@aziizziana
Copy link

#take

@dorothykiz1 dorothykiz1 changed the title Fix flake8 violations for test_step_detect.py and test/test_rm.py files Fix flake8 violations for all files in the asv/ directory Mar 1, 2022
@datapythonista
Copy link
Member

@dorothykiz1, maybe here what you can do is:

  • Fix the first few errors in the list (the ones before asv/plugins)
  • Split this issue in 3, one for plugins, one for commands and one for extern

What do you think?

@dorothykiz1
Copy link
Contributor Author

@datapythonista makes total sense,let me do this

@dorothykiz1 dorothykiz1 changed the title Fix flake8 violations for all files in the asv/ directory Fix flake8 violations for all files in the asv/plugins/ directory Mar 1, 2022
@LucyJimenez
Copy link
Contributor

@datapythonista, @dorothykiz1 I'm going to work on this one.

@datapythonista
Copy link
Member

All seem to be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants