Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add airflow.extraEnvFrom value #515

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matt2930
Copy link

@matt2930 matt2930 commented Feb 2, 2022

Signed-off-by: Matthew Altberg matthew.altberg@strong.io

What issues does your PR fix?

What does your PR do?

This PR add the extraEnvFrom field to values.yml, and uses these values to populate envFrom in pods.tpl. Adding this field means that users can now define envFrom: values, so that entire secret and config maps can be used

Checklist

For all Pull Requests

For releasing ONLY

Signed-off-by: Matthew Altberg <matthew.altberg@strong.io>
@thesuperzapper thesuperzapper changed the title feat: add airflow.extraEnvFrom field to values.yml and pods.tpl feat: add airflow.extraEnvFrom value Mar 23, 2022
@thesuperzapper thesuperzapper removed the request for review from gsemet March 23, 2022 23:10
@thesuperzapper thesuperzapper added the status/needs-discussion status - this needs discussion label Mar 23, 2022
@leticiasss
Copy link

any update on this issue?

@marios-pz
Copy link

marios-pz commented Jan 29, 2025

Is there a timeline on merging this PR? This feature is very important for my workflow and I would like to know if I will be able to get it on this month.

@LyKos4
Copy link

LyKos4 commented Feb 25, 2025

Is there currently a way to get a value from a kubernetes secret ?

I have tried adding in the values.yml the below but it doesn't work

secret:
- envName: "SECRET_NAME"
secretName: "airflow-kubernetes-secret"
secretKey: "SECRET_NAME"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/needs-discussion status - this needs discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add airflow.extraEnvFrom value
6 participants