Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dataset template test for load_data #51

Open
lgvaz opened this issue Sep 30, 2020 · 1 comment
Open

Add dataset template test for load_data #51

lgvaz opened this issue Sep 30, 2020 · 1 comment
Assignees
@lgvaz
Labels
enhancement New feature or request

Comments

@lgvaz
Copy link
Contributor

lgvaz commented Sep 30, 2020

🚀 Feature

A simple test to check if the given url is reachable would suffice.
@lgvaz lgvaz added enhancement New feature or request help wanted Extra attention is needed labels Sep 30, 2020
@lgvaz lgvaz self-assigned this Sep 30, 2020
@lgvaz lgvaz removed the help wanted Extra attention is needed label Sep 30, 2020
@lgvaz
Copy link
Contributor Author

lgvaz commented Sep 30, 2020

The test itself is not so straight forward to implement because the data is downloaded inside load_data and the URL is not exposed.

A hacky solution would be to check if load_data is running for at least a minimum ammount of seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lgvaz lgvaz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lgvaz