fix: add tolerations during reset pod creation #369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Applied in 84a7536 Sorry, I wasn't familiar with the process for how we apply changes from PR to the platform (it's not a simple merge), so the commit shows up under my name. |
|
No problem, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
While replication pods took tolerations into consideration, reset pods were created without tolerations, which resulted in Pending pods due to node taints.
How
Create reset pods with provided tolerations, just like replication pods. Closes airbytehq/airbyte#48380
Recommended reading order
airbyte-workload-launcher/src/main/kotlin/pods/factories/ReplicationPodFactory.ktCan this PR be safely reverted and rolled back?