Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@vx/shape: "^0.0.189" and viewsource code #469

Closed
khcd opened this issue Jun 23, 2019 · 1 comment
Closed

@vx/shape: "^0.0.189" and viewsource code #469

khcd opened this issue Jun 23, 2019 · 1 comment

Comments

@khcd
Copy link

khcd commented Jun 23, 2019

Hi, nice one with VX. Been looking at your viewsource demos: https://viewsource.now.sh/bitcoin the graph doesn't show when using @vx/shape: "^0.0.189" all seems fine when using @vx/shape: "0.0.131".

I can submit a PR if I find what it is although thought I'd submit this issue also.

@hshoff
Copy link
Member

hshoff commented Jun 25, 2019

Hi, thanks for checking out vx and viewsource. Yes, there have been some breaking changes to vx since making the viewsource demos. This issue is more applicable to: https://github.com/hshoff/viewsource so going to close this here and we can follow up in the viewsource repo here: hshoff/viewsource#4

Breaking changes can be found in the changelog here: https://github.com/hshoff/vx/blob/master/CHANGELOG.md

A summary of the biggest breaking change can be found here: #383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants