-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Added Google Maps Circle, Polygon, Polyline, MapType Support #722
[iOS] Added Google Maps Circle, Polygon, Polyline, MapType Support #722
Conversation
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome, thanks for taking this on! just one question.
@@ -502,9 +498,6 @@ class MapView extends React.Component { | |||
onMapReady: this._onMapReady, | |||
onLayout: this._onLayout, | |||
}; | |||
if (Platform.OS === 'ios' && ANDROID_ONLY_MAP_TYPES.includes(props.mapType)) { | |||
props.mapType = MAP_TYPES.STANDARD; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you consider keeping this check in case someone is still using mapkit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gilbox good point! I can add this check back and base it off the platform and provider
9575256
to
0ce4b3e
Compare
Added the check back |
this lgtm.. @spikebrehm wanna take a peek? |
@gilbox @spikebrehm Just added circle support |
👍 |
👍 |
This is perfect! Guys please merge this pull-request!! |
LGTM! Thanks 🍻 |
Needed the ability to draw on maps and switch the base map using the Google Maps SDK so I took a stab at adding this support.